Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankey: properly set coordinates of node's origin prior to drag operation #3564

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

antoinerg
Copy link
Contributor

Fixes #3563

@alexcjohnson
Copy link
Collaborator

Yep, that fixes it for me! Can we 🔒 it with a test?

@antoinerg
Copy link
Contributor Author

antoinerg commented Feb 21, 2019

I added a new test in 1f73366 for drag interactions. The test fails without the fix introduced in 08e5a50!

Thank you @alexcjohnson for catching this 🪲 !

@antoinerg antoinerg added bug something broken status: reviewable labels Feb 21, 2019
@antoinerg antoinerg added this to the v1.45.0 milestone Feb 21, 2019
@@ -905,6 +906,57 @@ describe('sankey tests', function() {
});
});

describe('Test drag interactions:', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Fantastic test! Thanks!

@etpinard
Copy link
Contributor

Nicely done 💃

@antoinerg antoinerg merged commit 3fc50cc into master Feb 21, 2019
@antoinerg antoinerg deleted the sankey2-fix-drag-origin branch February 21, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants