Fixing cone plots lighting & rendering on some hardware including CircleCI image test #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Mar 1, 2019
package.json
Outdated
| @@ -72,7 +72,7 @@ | |||
| "es6-promise": "^3.0.2", | |||
| "fast-isnumeric": "^1.1.2", | |||
| "font-atlas-sdf": "^1.3.3", | |||
| "gl-cone3d": "^1.2.3", | |||
| "gl-cone3d": "git://github.com/gl-vis/gl-cone3d.git#dcf87dd0dc237c2bdf66ff59e2a1d9febf13527f", | |||
There was a problem hiding this comment.
|
Wow. Thank you SO much for doing this. Cones are finally robustly tested! 💃 💃 after a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gl-cone3dmodule in this PR is aligned with the latestgl-mehs3dcode in regards with lighting position, shading algorithms. Also some unused files, codes and parameters removed from thegl-cone3dcode.Finally the indexing and floating points are debugged & fixed so that the baselines which include the
conetrace type could be tested usingCircleCIimage test.@plotly/plotly_js