Merge pull request #3591 from plotly/fix-noci-cone-plots

Fixing cone plots lighting & rendering on some hardware including CircleCI image test
plotly · Mar 1, 2019 · 98d9baa · 98d9baa
2 parents 4877a9c + 9390d82
commit 98d9baa
Show file tree

Hide file tree

Showing 12 changed files with 5 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -72,7 +72,7 @@
     "es6-promise": "^3.0.2",
     "fast-isnumeric": "^1.1.2",
     "font-atlas-sdf": "^1.3.3",
-    "gl-cone3d": "^1.2.3",
+    "gl-cone3d": "^1.3.0",
     "gl-contour2d": "^1.1.5",
     "gl-error3d": "^1.0.14",
     "gl-heatmap2d": "^1.0.5",

diff --git a/test/image/baselines/gl3d_cone-absolute.png b/test/image/baselines/gl3d_cone-absolute.png
diff --git a/test/image/baselines/gl3d_cone-autorange.png b/test/image/baselines/gl3d_cone-autorange.png
diff --git a/test/image/baselines/gl3d_cone-lighting.png b/test/image/baselines/gl3d_cone-lighting.png
diff --git a/test/image/baselines/gl3d_cone-newplot_reversed_ranges.png b/test/image/baselines/gl3d_cone-newplot_reversed_ranges.png
diff --git a/test/image/baselines/gl3d_cone-rossler.png b/test/image/baselines/gl3d_cone-rossler.png
diff --git a/test/image/baselines/gl3d_cone-simple.png b/test/image/baselines/gl3d_cone-simple.png
diff --git a/test/image/baselines/gl3d_cone-single.png b/test/image/baselines/gl3d_cone-single.png
diff --git a/test/image/baselines/gl3d_cone-wind.png b/test/image/baselines/gl3d_cone-wind.png
diff --git a/test/image/baselines/gl3d_cone-with-streamtube.png b/test/image/baselines/gl3d_cone-with-streamtube.png
diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js
@@ -96,8 +96,7 @@ function untestableFilter(mockName) {
     var cond = !(
         mockName === 'font-wishlist' ||
         mockName.indexOf('gl2d_') !== -1 ||
-        mockName.indexOf('mapbox_') !== -1 ||
-        mockName.indexOf('gl3d_cone-') !== -1
+        mockName.indexOf('mapbox_') !== -1
     );
 
     if(!cond) console.log(' -', mockName);