Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to call doneFnCompleted when it isn't set #3755

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

etpinard
Copy link
Contributor

fixes #3754

@plotly/plotly_js here's the hotfix, we should investigate why our tests didn't catch this though.

@etpinard etpinard added bug something broken status: reviewable labels Apr 10, 2019
@archmoj
Copy link
Contributor

archmoj commented Apr 10, 2019

💃

@antoinerg
Copy link
Contributor

Thanks for the fix @etpinard !!! 💃

@etpinard
Copy link
Contributor Author

Thanks for the review! I'm still trying to figure why our select_test.js are eating up console errors.

I'll release this fix later this afternoon.

... and spyOn of Lib.error to lock down #3755
@etpinard
Copy link
Contributor Author

9856354 🔒 down the fix. I was hoping to find a better to look for errors inside promise chains (I even tried bringing back Lib.promiseError cc #1705), but to no avail.

Oh well, I hope you think this will be good enough for 1.47.1.

@etpinard
Copy link
Contributor Author

Merging this thing in. 1.47.1 will be out in ~20 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught (in promise) TypeError: doneFnCompleted is not a function
3 participants