Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade acorn to v6 #4811

Merged
merged 1 commit into from
May 4, 2020
Merged

Downgrade acorn to v6 #4811

merged 1 commit into from
May 4, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 4, 2020

Folowing #4800 and #4802, now using acorn v7 the npm run preversion step failed with the following message:
Screenshot from 2020-05-04 18-21-00

This PR fixes that by using latest v6 version i.e. without increasing audit warnings.

cc: @plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 4, 2020
@archmoj archmoj added this to the v1.54.1 milestone May 4, 2020
@nicolaskruchten
Copy link
Contributor

Dancer

@archmoj archmoj merged commit aa8ccc6 into master May 4, 2020
@archmoj archmoj deleted the use-acorn-v6 branch May 4, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants