Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case of div with zero dimension when positioning unified hover box #5913

Merged
merged 14 commits into from
Aug 31, 2021
Merged

Handle case of div with zero dimension when positioning unified hover box #5913

merged 14 commits into from
Aug 31, 2021

Commits on Aug 30, 2021

  1. handle case of zero outerHeight to bring back unified hover in docume… 

    …ntaion website
    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    df50898 View commit details
    Browse the repository at this point in the history

  2. log for PR 5913

    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    11f159f View commit details
    Browse the repository at this point in the history

  3. Revert "handle case of zero outerHeight to bring back unified hover i… 

    …n documentaion website"

This reverts commit df50898.
    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    6f549d2 View commit details
    Browse the repository at this point in the history

  4. add fallback in the case of zero width or height

    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    ed8430c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into unified-hover-with-… 

    …zero-outer-height
    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    60fe0fe View commit details
    Browse the repository at this point in the history

  6. use _paper instaed of _paperdiv - remove fallback

    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    b53c387 View commit details
    Browse the repository at this point in the history

  7. outerContainer is not used in createSpikelines - remove it

    @archmoj
    archmoj committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    5f1e2fc View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. pass _paper.node() similar to other places

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9ab9444 View commit details
    Browse the repository at this point in the history

  2. do not d3.select _paper.node()

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9425a24 View commit details
    Browse the repository at this point in the history

  3. simplify logic

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    76ce3aa View commit details
    Browse the repository at this point in the history

  4. additional fix to 9ab9444

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    a783989 View commit details
    Browse the repository at this point in the history

  5. use opts.container instead of container3.node()

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    a7a472e View commit details
    Browse the repository at this point in the history

  6. no need to declare extra variables

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    0ac2420 View commit details
    Browse the repository at this point in the history

  7. revise createHoverText calling arguments

    @archmoj
    archmoj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    2c184fd View commit details
    Browse the repository at this point in the history