Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dash length list to dash property validator #1136

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Aug 29, 2018

Fix for #1107

This PR introduces a new custom DashValidator. This is a EnumerationValidator subclass that adds a regular expression to the acceptable values list that covers the dash list case.

It also customizes the validator description so that we don't simple tell users that their specification must match the regular expression ^\d+(\.\d+)?(px|%)?((,|\s)\s*\d+(\.\d+)?(px|%)?)*$ 🙂

The new DashValidator is used for all dash properties that support dash lists. At the moment this includes the dash properties in all non-WebGL trace types. The validators for the dash properties in WebGL trace types have not been modified.

cc @aplowman

@jonmmease jonmmease merged commit d8095de into master Aug 29, 2018
@nicolaskruchten nicolaskruchten deleted the dash_validator branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant