Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fonts and correct plot schema access #52

Merged

Conversation

bpostlethwaite
Copy link
Member

@bpostlethwaite bpostlethwaite commented Nov 8, 2017

closes #51

Add a few default fonts with fallbacks that should cover MacOS, iOS, Windows and Android (sorry Linux...).

Actually get around to testing and using the PlotSchema accessors. Turns out I had forgotten to pass in parts. That behaviour is corrected and tested.

Use the accessors to automatically lookup min and max values for Numeric and other widgets.

@bpostlethwaite bpostlethwaite changed the base branch from master to reorganizeFolderStructure November 8, 2017 17:23
@alexcjohnson
Copy link
Collaborator

Love it. As we've discussed before we may need separate UI bounds and hard bounds for certain items, but we can address that later on as it'll need to be a plotly.js addition.
💃

@bpostlethwaite bpostlethwaite merged commit 601fb70 into reorganizeFolderStructure Nov 13, 2017
@bpostlethwaite bpostlethwaite deleted the DefaultFontsAndCorrectPlotSchemaAccess branch November 13, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants