Make cytoscape a peer dependency #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be nice. This readme commit by @maxkfranz 0edbf07 basically already guides users to install Cytoscape as a peer dep anyway... |
|
@Secretmapper Could you resolve the package.json conflict so maybe @kinimesi (having just merged #53) can then merge this? :) |
|
@kinimesi (or someone else), could this get merged sometime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cytoscape is used by the user of react-cytoscape, it should be a peer dependency. This prevents instances where you get multiple copies of cytoscape.
#21
#17
As mentioned, by @akx in issue 17, this is similar to having react as a peer dependency. Not having it as a peer dependency can make
cytoscapejs.usenot work, as you can end up with multiple copies of cytoscapejs (which is what prompted my opening of this issue in the first place)FYI: This PR does not update the package-lock.json