Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cytoscape should be a peer dependency #17

Closed
cappslock opened this issue Feb 20, 2019 · 2 comments
Closed

cytoscape should be a peer dependency #17

cappslock opened this issue Feb 20, 2019 · 2 comments

Comments

@cappslock
Copy link

Rather than bundling cytoscape, it would be nice to express it as a peer dependency pegged to the major version. I'm happy to provide a PR for this.

@maxkfranz
Copy link
Collaborator

A peer dependency would not be appropriate within the semantics of package.json. This is a proper dependency, not a plugin dependency.

@akx
Copy link
Contributor

akx commented Sep 30, 2019

Seconding this.

The same way react and react-dom are peer dependencies here, cytoscape should be.

I bumped into a problem where .use()ing a Cytoscape plugin didn't work because there were multiple versions of Cytoscape bundled in, and useing the plugin only registered it in the Cytoscape not being used by react-cytoscapejs.

akx added a commit to akx/react-cytoscapejs that referenced this issue Jul 6, 2022
akx added a commit to akx/react-cytoscapejs that referenced this issue Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants