fix(sankey): add missing motion typedefs and proptypes

plouc · May 18, 2020 · bc5489c · bc5489c
1 parent 354ef24
commit bc5489c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/packages/sankey/index.d.ts b/packages/sankey/index.d.ts
@@ -7,13 +7,15 @@
  * file that was distributed with this source code.
  */
 import * as React from 'react'
-import { Theme, CssMixBlendMode, Box } from '@nivo/core'
+import { Theme, CssMixBlendMode, Box, Dimensions, MotionProps } from '@nivo/core'
 import { OrdinalColorsInstruction, InheritedColorProp } from '@nivo/colors'
 import { LegendProps } from '@nivo/legends'
 
 declare module '@nivo/sankey' {
-    export class Sankey extends React.Component<Data & SankeyProps & Dimensions> {}
-    export class ResponsiveSankey extends React.Component<Data & SankeyProps> {}
+    interface SharedProps extends Data, MotionProps, SankeyProps {}
+
+    export class Sankey extends React.Component<SharedProps & Dimensions> {}
+    export class ResponsiveSankey extends React.Component<SharedProps> {}
 
     export interface SankeyDataNode {
         id: string | number
@@ -118,9 +120,4 @@ declare module '@nivo/sankey' {
 
         legends: LegendProps[]
     }>
-
-    interface Dimensions {
-        height: number
-        width: number
-    }
 }
diff --git a/packages/sankey/src/props.js b/packages/sankey/src/props.js
@@ -8,7 +8,7 @@
  */
 import PropTypes from 'prop-types'
 import { sankeyCenter, sankeyJustify, sankeyLeft, sankeyRight } from 'd3-sankey'
-import { noop, blendModePropType } from '@nivo/core'
+import { noop, blendModePropType, motionPropTypes } from '@nivo/core'
 import { ordinalColorsPropType, inheritedColorPropType } from '@nivo/colors'
 import { LegendPropShape } from '@nivo/legends'
 
@@ -90,6 +90,8 @@ export const SankeyPropTypes = {
             PropTypes.func,
         ])
     ).isRequired,
+
+    ...motionPropTypes,
 }
 
 export const SankeyDefaultProps = {