-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for React 17 (address NPM warns) #1256
Comments
There shouldn't be any breaking changes for us in React 17, so I don't see an issue with the version ranges being updated. As far as |
I'm having the same or similar problem. I'm tying to use Nivo in my project and when I npm install @nivo/core I get a dependency tree error message. Is there a way to resolve this issue? My exact error message reads: code ERESOLVE If it helps, I'm also using... "react": "^17.0.1" |
@jmischka |
@farshidinanloo Is this a bug in NPM? If so is there any issue that can be linked here? I am having the exact same issue that @jmischka described, but downgrading NPM is not really an option. |
We are seeing the same issue with npm 7. You can use |
Dear Folks, Congrats for a nice library :) I see that the package range has been fixed in #1283. However, as far as I can see this change did not propagate to npm where the latest available version for nivo is still 0.31. Is there no way to install the version of nivo with the corrected ranges with npm? Tahnks! |
@mircealungu You need to use the scoped packages, |
Is your feature request related to a problem? Please describe.
I'm requesting React 17 support. My package.json contains:
I don't know of any actual problems with the library working with React 17, but since updating, when I run npm install I see:
As well, this dependent library:
npm WARN react-motion@0.5.2 requires a peer of react@^0.14.9 || ^15.3.0 || ^16.0.0 but none is installed. You must install peer dependencies yourself.
^ I don't see any updated versions of that library since react 17's release though.
Describe the solution you'd like
I'd like to suggest that the relevant package.json files be updated to allow the 17.x versions of React.
nivo/packages/bar/package.json
Line 41 in fd73145
Describe alternatives you've considered
The alternative is to leave this as is since it seems still functionally correct and ignore the warning noise on npm install.
Additional context
Just want to say thanks for all the effort that this library has gotten recently.
The text was updated successfully, but these errors were encountered: