Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): fix stacked bars when key is missing #1291

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Conversation

wyze
Copy link
Contributor

@wyze wyze commented Nov 17, 2020

Close #1289

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 17, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd79509:

Sandbox Source
nivo Configuration
nivo-website Configuration
nivo basic demo (forked) Issue #1289

@wyze wyze requested a review from plouc November 17, 2020 23:13
Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc plouc merged commit 484235f into master Nov 18, 2020
@plouc plouc deleted the stacked-bar-nan branch November 18, 2020 00:54
@joealden
Copy link

@wyze sorry to bug you about this, but do you have an idea of when this fix will be included in a release? My team recently updated to 0.65.1 from 0.63.0 without realising this problem broke one of our graphs, and we'd prefer to not to have to rollback to a previous version as we've started writing code that depends on some of the new features introduced recently :)

@wyze
Copy link
Contributor Author

wyze commented Nov 27, 2020

@joealden I just published a new release, so you should be good to pull it in!

@joealden
Copy link

@wyze I just saw that, thanks a lot!

ddavydov pushed a commit to netronixgroup/nivo that referenced this pull request Apr 8, 2021
* fix(bar): fix stacked bars when key is missing

Close plouc#1289

* chore(bar): add tests that pass in v0.63.0

* fix(bar): update logic to reproduce old behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar keys need to be identical
3 participants