Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axes): rtl issue with x-axis #1349

Merged
merged 1 commit into from Dec 18, 2020
Merged

fix(axes): rtl issue with x-axis #1349

merged 1 commit into from Dec 18, 2020

Conversation

alikazemkhanloo
Copy link
Contributor

This will fix RTL issue with the x-axis label. When using tickRotate, text-align is incorrect. Most RTL issues are solvable using a small trick like this one.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e44bcc0:

Sandbox Source
nivo Configuration
nivo-website Configuration

@wyze
Copy link
Contributor

wyze commented Dec 15, 2020

Hi @alikazemkhanloo, how can I test this out?

@alikazemkhanloo
Copy link
Contributor Author

Hi @wyze, you need to use dir='rtl' on html. Then use tickRotation: 45 for axisBottom config. you will see something like this without this PR.

Screen Shot 1399-09-26 at 12 50 39

Also, you can inspect the demo page and add dir="rtl" to see the issue I'm trying to solve.

@wyze
Copy link
Contributor

wyze commented Dec 18, 2020

Looks good to me, thanks!

@wyze wyze changed the title fix rtl issue with x-axis fix(axes): rtl issue with x-axis Dec 18, 2020
@wyze wyze merged commit 95f3b34 into plouc:master Dec 18, 2020
ddavydov pushed a commit to netronixgroup/nivo that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants