Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axes): restore memoization #1521

Merged
merged 5 commits into from
May 22, 2021

Conversation

cameronevans
Copy link
Contributor

fixes: #1519
restore memoization that was removed in 73f9803

@wyze
Copy link
Contributor

wyze commented May 15, 2021

Thanks for the PR! It looks like we might be losing some type information. We'll need to get that fixed before we can merge this in.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit abbf694:

Sandbox Source
nivo Configuration
nivo-website Configuration
proud-bush-5cnok Issue #1519

@wyze wyze changed the title restore axes memoization fix(axes): restore memoization May 22, 2021
@wyze wyze merged commit 729cd55 into plouc:master May 22, 2021
@wyze
Copy link
Contributor

wyze commented May 22, 2021

Thanks for this!

@cameronevans cameronevans deleted the restore-axes-memoization branch May 23, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridLines & Axis rerendering on tooltip render
2 participants