chore(core): revert ResizeObserver changes #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 20ce648:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts "fix(core): avoid occasional "ResizeObserver loop" error (#1466)"
This reverts commit 7f88e10.
Close #1561
I'm not sure we had a report about the ResizeObserver loop, but now that the linked issue was created the reverted code is the offender. If you try the latest released version of nivo you can easily reproduce the jumpy tooltip.
@ollwenjones Sorry I had to revert your PR, but if you want to try another attempt at fixing the ResizeObserver loop error you were receiving. I'll be more than happy to review it and ensure our tooltip doesn't regress this time.