Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): expose weekdayTicks prop on TimeRange component #1634

Merged
merged 6 commits into from
Jun 28, 2021

Conversation

brammitch
Copy link
Contributor

@brammitch brammitch commented Jun 25, 2021

On the new TimeRange component, the weekday tick marks are set to Monday/Wednesday/Friday. This PR gives the user an option to change them, or remove them altogether by passing an empty array.

Updates were made to the Storybook showing both alternative options.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5856e09:

Sandbox Source
nivo Configuration
nivo-website Configuration

Copy link
Contributor

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just want a more strict type.

Also, can you merge master or rebase. I merged in a PR containing the changes you have in .storybook folder.

packages/calendar/src/types.ts Outdated Show resolved Hide resolved
website/src/data/components/time-range/props.js Outdated Show resolved Hide resolved
Copy link
Contributor

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wyze wyze changed the title feat(calendar): Allow user to set weekday tick marks on TimeRange component feat(calendar): expose weekdayTicks prop on TimeRange component Jun 28, 2021
@wyze wyze merged commit efafa01 into plouc:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants