fix(legends): Respect theme fill color #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #814 - or so I hope The fill color of the legend text is currently not themeable because the fill from the theme is always overwritten by either the style from the local component state (my understanding is that this style is from mouse hover effects) or the value of the `textColor` prop which defaults to `black`. This line would still allow the local state to take precendence, but would then pick the theme's legend text fill color as a backup and only then resort to the `textColor` props. Disclaimer: This is the first time ever I look at the Nivo code so there might be more subtle things that I'm overlooking.
wyze
approved these changes
Jun 24, 2020
wyze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #814 - or so I hope
The fill color of the legend text is currently not themeable
because the fill from the theme is always overwritten by either
the style from the local component state (my understanding is
that this style is from mouse hover effects) or the value of
the
textColorprop which defaults toblack.This line would still allow the local state to take precendence,
but would then pick the theme's legend text fill color as a backup
and only then resort to the
textColorprops.Disclaimer: This is the first time ever I look at the Nivo code
so there might be more subtle things that I'm overlooking.