mksquashfs/unsquashfs: fix compilation with glibc 2.25+ #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From glibc 2.25 release notes: https://sourceware.org/ml/libc-alpha/2017-02/msg00079.html "* The inclusion of <sys/sysmacros.h> by <sys/types.h> is deprecated. This means that in a future release, the macros “major”, “minor”, and “makedev” will only be available from <sys/sysmacros.h>." See glibc bug https://sourceware.org/bugzilla/show_bug.cgi?id=19239 .
|
glibc 2.28 no longer includes <sys/sysmacros.h> from <sys/types.h>, which breaks the build on a glibc 2.28+ system without this change. |
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Sep 1, 2018
Since glibc 2.28, sys/sysmacros.h is no longer included from sys/types.h This patch fixes the resulting build error by explicitly including sys/sysmacros.h See also plougher/squashfs-tools#52 Signed-off-by: Richard Kunze <richard.kunze@web.de> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Sep 27, 2018
Since glibc 2.28, sys/sysmacros.h is no longer included from sys/types.h This patch fixes the resulting build error by explicitly including sys/sysmacros.h See also plougher/squashfs-tools#52 Signed-off-by: Richard Kunze <richard.kunze@web.de> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit ed0e556) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Sep 27, 2018
Since glibc 2.28, sys/sysmacros.h is no longer included from sys/types.h This patch fixes the resulting build error by explicitly including sys/sysmacros.h See also plougher/squashfs-tools#52 Signed-off-by: Richard Kunze <richard.kunze@web.de> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit ed0e556) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
awanga
pushed a commit
to awanga/alt-f-next
that referenced
this pull request
May 15, 2020
Since glibc 2.28, sys/sysmacros.h is no longer included from sys/types.h This patch fixes the resulting build error by explicitly including sys/sysmacros.h See also plougher/squashfs-tools#52 Signed-off-by: Richard Kunze <richard.kunze@web.de> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From glibc 2.25 release notes:
https://sourceware.org/ml/libc-alpha/2017-02/msg00079.html
"* The inclusion of <sys/sysmacros.h> by <sys/types.h> is deprecated.
This means that in a future release, the macros “major”, “minor”, and
“makedev” will only be available from <sys/sysmacros.h>."
See glibc bug https://sourceware.org/bugzilla/show_bug.cgi?id=19239 .