Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order TRecord in InfernoType to preserve existing serialization #106

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Re-order TRecord in InfernoType to preserve existing serialization #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions inferno-types/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Revision History for inferno-types
*Note*: we use https://pvp.haskell.org/ (MAJOR.MAJOR.MINOR.PATCH)

## 0.4.2.0 -- 2024-03-18
* Re-order `TRecord` in `InfernoType` so that existing serialization doesn't break

## 0.4.1.0 -- 2024-03-18
* HLint everything

Expand Down
2 changes: 1 addition & 1 deletion inferno-types/inferno-types.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cabal-version: >=1.10
name: inferno-types
version: 0.4.1.0
version: 0.4.2.0
synopsis: Core types for Inferno
description: Core types for the Inferno language
category: DSL,Scripting
Expand Down
4 changes: 2 additions & 2 deletions inferno-types/src/Inferno/Types/Syntax.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,12 @@
| TBase BaseType
| TArr InfernoType InfernoType
| TArray InfernoType
| -- | A record type containing *at least* the given fields (with types) and a row variable representing any potential other fields
TRecord (Map.Map Ident InfernoType) RestOfRecord
| TSeries InfernoType
| TOptional InfernoType
| TTuple (TList InfernoType)
| TRep InfernoType
| -- | A record type containing *at least* the given fields (with types) and a row variable representing any potential other fields
TRecord (Map.Map Ident InfernoType) RestOfRecord
deriving (Show, Eq, Ord, Data, Generic, ToJSON, FromJSON, NFData, Hashable)
deriving anyclass (Serialize)

Expand Down Expand Up @@ -719,7 +719,7 @@
dataTypeOf _ = ty_IStr
dataCast1 = gcast1

con_ISEmpty, con_ISStr, con_ISExpr :: Constr

Check warning on line 722 in inferno-types/src/Inferno/Types/Syntax.hs

View workflow job for this annotation

GitHub Actions / build 

Suggestion in con_ISEmpty in module Inferno.Types.Syntax: Use camelCase ▫︎ Found: "con_ISEmpty, con_ISStr, con_ISExpr :: Constr" ▫︎ Perhaps: "conISEmpty, con_ISStr, con_ISExpr :: Constr"
con_ISEmpty = mkConstr ty_IStr "ISEmpty" [] Data.Prefix
con_ISStr = mkConstr ty_IStr "ISStr" [] Data.Prefix
con_ISExpr = mkConstr ty_IStr "ISExpr" [] Data.Prefix
Expand Down