Fix broken vs code extension build + lsp server #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smurphy8
approved these changes
Dec 29, 2022
| @@ -70,4 +71,6 @@ executable inferno-lsp-server | |||
| ghc-options: -Wall -Wincomplete-uni-patterns -Wincomplete-record-updates -threaded -rtsopts -with-rtsopts=-T | |||
| build-depends: | |||
| base >=4.7 && <5 | |||
| , inferno-core | |||
There was a problem hiding this comment.
Btw, we need version bounds on all dependencies in order to upload to hackage. (We can add this before the next update)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nix build of the VS code inferno LSP extension was broken.
This also re-introduces the LSP server binary and re-routes the logging back to stderr, since the server communicates via stdio with the VS Code extension.
Finally, this also includes some M1 specific tweaks due to some broken packages:
ghc884is not supported on the M1, the earliest supported one beingghc8107