pull the recent update from moby #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestResumableRequestHeaderTooMuchFailures: prepare for Go 1.14 changes
…dentials TestLoginFailsWithBadCredentials: prepare for Go 1.14 changes
full diff: gotestyourself/gotest.tools@v2.3.0...v3.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Fix typos in dockerignore_test.go
bump gotest.tools v3.0.1 for compatibility with Go 1.14
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This extracts parsing the driver's configuration to a function, and uses the same function both when initializing the driver, and when validating logging options. Doing so allows validating if the provided options are in the correct format when calling `ValidateOpts`, instead of resulting in an error when initializing the logging driver. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This adds a new `fluentd-request-ack` logging option for the Fluentd logging driver. If enabled, the server will respond with an acknowledgement. This option improves the reliability of the message transmission. This change is not versioned, and affects all API versions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Dont assign the --bip value directly to the subnet for the default bridge. Instead use the network value from the ParseCIDR output Addresses: #40392 Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
Fluentd: add fluentd-async, fluentd-request-ack, and deprecate fluentd-async-connect
API: remove deprecated "filter" parameter for API v1.41 and up
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
fix goimports
```
daemon/logger/splunk/splunk_test.go:33: File is not `goimports`-ed (goimports)
envKey: "a",
envRegexKey: "^foo",
labelsKey: "b",
tagKey: "c",
integration/build/build_test.go:41: File is not `goimports`-ed (goimports)
rm: false,
forceRm: false,
integration/image/remove_unix_test.go:49: File is not `goimports`-ed (goimports)
Root: d.Root,
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Fix more goimports
The namespaces com.docker.*, io.docker.*, org.dockerproject.* have been documented to be reserved for Docker's internal use. Co-Authored-By: Sebastiaan van Stijn <thaJeztah@users.noreply.github.com> Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Set the bip network value as the subnet
The latest `ltsc2019` image (`10.0.17763.1039`) appear to be broken, and even a `RUN Write-Host hello` hangs. Temporarily switching back to an older version so that CI doesn't fail. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Jenkinsfile: temporarily pin windows image to 10.0.17763.973
Co-authored-by: Yves Brissaud <yves.brissaud@gmail.com> Signed-off-by: Anca Iordache <anca.iordache@docker.com>
This test was disabled in the past, but re-enabled when we upgraded docker-py to 4.2.0. The test looks to be still flaky though, so skipping it again: ``` [2020-02-10T23:40:44.429Z] =================================== FAILURES =================================== [2020-02-10T23:40:44.429Z] __________________ AttachContainerTest.test_attach_no_stream ___________________ [2020-02-10T23:40:44.429Z] tests/integration/api_container_test.py:1250: in test_attach_no_stream [2020-02-10T23:40:44.429Z] assert output == 'hello\n'.encode(encoding='ascii') [2020-02-10T23:40:44.429Z] E AssertionError: assert b'' == b'hello\n' [2020-02-10T23:40:44.429Z] E Right contains more items, first extra item: 104 [2020-02-10T23:40:44.429Z] E Use -v to get the full diff [2020-02-10T23:40:44.429Z] ------- generated xml file: /src/bundles/test-docker-py/junit-report.xml ------- ```` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-py: skip flaky AttachContainerTest::test_attach_no_stream (again)
enforce reserve internal labels.
This reverts commit fa24179. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The documentation for validate_vendor_used in hack/validate/vendor states that a warning will be emitted if license information cannot be found in a vendored package. However, because the script is run with pipefail set (owing to the inclusion of the common validation script .validate) and `grep -c` is used, the entire script will fail whenever license information cannot be found in a vendored package. Signed-off-by: Chris Price <cprice@mirantis.com>
Specify base64url rather than base64. Also correct other links to the base64url section of RFC4648 Signed-off-by: Mike Bush <mpbush@gmail.com>
Fixes #33434 - API docs to specify using base64url
Support cgroup as in Rootless Podman. Requires cgroup v2 host with crun. Tested with Ubuntu 19.10 (kernel 5.3, systemd 242), crun v0.12.1. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…gsCreateAndDelete Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…nspect Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
While the docker cli may be sending a "version" header, this header is not part of the API, or at least should not determin what API version is used. This code was added in c0afd9c, to adjust the handling of requests when an older version of the API was used, but because the code relied on the "version" header set by the CLI, it didn't work with other clients (e.g. when using cURL to make an API request). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
On startup, actually shutdown the container.
daemon: various nits and small fixes
Fixed typo in inventor comments.
Integration: fix various issues in "config" and "secret" tests
vendor: update buildkit to ae7ff174
swarm: fix API version detection
Support for PidsLimit was added to SwarmKit in moby/swarmkit/pull/2415, but never exposed through the Docker remove API. This patch exposes the feature in the repote API. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
This appeared to be unused because we no longer generate a uuid using this package. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Support reading multiple bytes in escapeProxy
Commit 1470697 marked this flag as deprecated, but inadvertedtly used the plural (which is used for `daemon.json`, but not for the flag name. This fixes the inccorect name of the flag. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
update containerd to v1.3.4
vendor: pkg/errors v0.9.1, mespath/go-jmespath v0.3.0
Add stats options to not prime the stats
add zombie check for container when killing it
Add API support for PidsLimit on services
Reduce allocations for logfile reader
fix --cluster-store-opt deprecation annotation
daemon: remove distribution/uuid package
enhance storage-opt validation logic in overlay2 driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.