Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.2.1 shows jazz_fingers as application name #25

Closed
aried3r opened this issue Jul 21, 2020 · 5 comments · Fixed by #26
Closed

Version 5.2.1 shows jazz_fingers as application name #25

aried3r opened this issue Jul 21, 2020 · 5 comments · Fixed by #26

Comments

@aried3r
Copy link
Contributor

aried3r commented Jul 21, 2020

Version 5.2.0:

$ rails console
2.7.1 (my_app_name)[1] »

Version 5.2.1:

$ rails console
2.7.1 (jazz_fingers)[1] »
@plribeiro3000
Copy link
Owner

Which version of Rails are you using?

@aried3r
Copy link
Contributor Author

aried3r commented Jul 22, 2020

Sorry, forgot to mention in the issue. I'm using Rails 6.0.3.2.

@aried3r
Copy link
Contributor Author

aried3r commented Jul 22, 2020

Ah, I can see it now. 57c97fa tries to fix a deprecation warning, but removed the return statement. Now jazz_fingers is always returned.

Should we return a default like this instead of maybe throwing an exception or displaying a warning? In which cases would this not return a value?

@plribeiro3000
Copy link
Owner

Ouch. Good catch.

Could you open a PR?

@plribeiro3000
Copy link
Owner

I guess just adding return would be enough.

If we can get the application name let use it otherwise use the default which is the gem name.

aried3r added a commit to aried3r/jazz_fingers that referenced this issue Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants