Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test optional #28

Closed
bansan85 opened this issue Jul 5, 2021 · 3 comments
Closed

Make test optional #28

bansan85 opened this issue Jul 5, 2021 · 3 comments

Comments

@bansan85
Copy link
Contributor

bansan85 commented Jul 5, 2021

This will remove catch2 dependency. This could be done by adding a symbol -DNO_TEST for example.

I can do it if you want.

@shravanrn
Copy link
Collaborator

shravanrn commented Jul 7, 2021

This is a header only library, so there is nothing really to build here assist from the tests and docs. If you want just the header you can just avoid the build :)
Closing this. Reopen if still think there is anything missing

@bansan85
Copy link
Contributor Author

@shravanrn Now that there is a make install to install headers and enable find_package feature, what do you think about moving tests and catch2 dependency as an option?

@shravanrn
Copy link
Collaborator

@bansan85 Yeah, I guess it makes sense. I think the behavior we would want is

  1. make build should just output a message saying "nothing to build, run make test or make install"

  2. make test should pull in the relevant dependencies, build tests and run the tests.

If you want to set this up, I'd be happy to merge it (don't forgot to update the commands for the CI testing also :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants