Refactor Source to store the specific matched pattern
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save the index of the relevant `AfxRulePattern` with the `Arc<Affix>` in `Source::Affix`. This allows us to retrieve morph rules from that specific pattern, rather than returning all rules in the `Affix`. Fixes #73
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 74.73% 74.88% +0.14%
==========================================
Files 24 24
Lines 3218 3237 +19
==========================================
+ Hits 2405 2424 +19
Misses 813 813
☔ View full report in Codecov by Sentry. |
tgross35
force-pushed
the
morph-specificity
branch
from
908190e
to
47fe1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the index of the relevant
AfxRulePatternwith theArc<Affix>inSource::Affix. This allows us to retrieve morph rules from that specific pattern, rather than returning all rules in theAffix.Fixes #73