Skip to content

Commit

Permalink
Fix detach in crd typing
Browse files Browse the repository at this point in the history
Used a . accidentally for a separator
  • Loading branch information
michaeljguarino committed May 5, 2024
1 parent c647a84 commit 090d627
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion controller/api/v1alpha1/globalservice_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func init() {
type Cascade struct {
// Whether you want to delete owned resources in Plural but leave kubernetes objects in-place
// +kubebuilder:validation:Optional
Detach *bool `json:"detach.omitempty"`
Detach *bool `json:"detach,omitempty"`

// Whether you want to delete owned resources in Plural and in the targeted k8s cluster
// +kubebuilder:validation:Optional
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion controller/docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ _Appears in:_

| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `detach.omitempty` _boolean_ | Whether you want to delete owned resources in Plural but leave kubernetes objects in-place | | Optional: {} <br /> |
| `detach` _boolean_ | Whether you want to delete owned resources in Plural but leave kubernetes objects in-place | | Optional: {} <br /> |
| `delete` _boolean_ | Whether you want to delete owned resources in Plural and in the targeted k8s cluster | | Optional: {} <br /> |


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down

0 comments on commit 090d627

Please sign in to comment.