craft hardwire agent health for our operator types (#1159)

pluralsh · Jul 9, 2024 · a58d296 · a58d296
1 parent dcc1a1f
commit a58d296
Show file tree

Hide file tree

Showing 23 changed files with 100 additions and 22 deletions.
diff --git a/controller/internal/controller/cluster_controller.go b/controller/internal/controller/cluster_controller.go
@@ -61,7 +61,7 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req reconcile.Request
 		logger.Error(err, "Unable to fetch cluster")
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkCondition(cluster.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	// Ensure that status updates will always be persisted when exiting this function.
 	scope, err := NewClusterScope(ctx, r.Client, cluster)
 	if err != nil {
@@ -144,7 +144,7 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req reconcile.Request
 		}
 	}
 	utils.MarkCondition(cluster.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionTrue, v1alpha1.SynchronizedConditionReason, "")
-
+	utils.MarkCondition(cluster.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 	return requeue, nil
 }
 
@@ -205,7 +205,7 @@ func (r *ClusterReconciler) handleExisting(cluster *v1alpha1.Cluster) (ctrl.Resu
 		}
 	}
 	utils.MarkCondition(cluster.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionTrue, v1alpha1.SynchronizedConditionReason, "")
-
+	utils.MarkCondition(cluster.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 	return requeue, nil
 }
 

diff --git a/controller/internal/controller/cluster_controller_test.go b/controller/internal/controller/cluster_controller_test.go
@@ -183,6 +183,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Status: metav1.ConditionFalse,
 							Reason: v1alpha1.ReadonlyConditionReason.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionTrue,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,
@@ -236,6 +241,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Status: metav1.ConditionFalse,
 							Reason: v1alpha1.ReadonlyConditionReason.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionTrue,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,
@@ -290,6 +300,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Status: metav1.ConditionFalse,
 							Reason: v1alpha1.ReadonlyConditionReason.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionTrue,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,
@@ -335,6 +350,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Reason:  v1alpha1.ReadonlyConditionReason.String(),
 							Message: v1alpha1.ReadonlyTrueConditionMessage.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionFalse,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:    v1alpha1.SynchronizedConditionType.String(),
 							Status:  metav1.ConditionFalse,
@@ -392,6 +412,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Reason:  v1alpha1.ReadonlyConditionReason.String(),
 							Message: v1alpha1.ReadonlyTrueConditionMessage.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionTrue,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,
@@ -440,6 +465,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Reason:  v1alpha1.ReadonlyConditionReason.String(),
 							Message: v1alpha1.ReadonlyTrueConditionMessage.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionTrue,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,
@@ -490,6 +520,11 @@ var _ = Describe("Cluster Controller", Ordered, func() {
 							Reason:  v1alpha1.ReadonlyConditionReason.String(),
 							Message: v1alpha1.ReadonlyTrueConditionMessage.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionTrue,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,

diff --git a/controller/internal/controller/customstackrun_controller.go b/controller/internal/controller/customstackrun_controller.go
@@ -64,6 +64,7 @@ func (r *CustomStackRunReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
 
+	utils.MarkCondition(stack.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewCustomStackRunScope(ctx, r.Client, stack)
 	if err != nil {
 		logger.Error(err, "failed to create custom stack run")

diff --git a/controller/internal/controller/deploymentsettings_controller.go b/controller/internal/controller/deploymentsettings_controller.go
@@ -65,12 +65,11 @@ func (r *DeploymentSettingsReconciler) Reconcile(ctx context.Context, req ctrl.R
 	if err := r.Get(ctx, req.NamespacedName, settings); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkCondition(settings.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	// make sure there is only one CRD object with the `global` name and the agent namespace
 	if settings.Name != deploymentSettingsName || settings.Namespace != deploymentSettingsNamespace {
 		return ctrl.Result{}, nil
 	}
-
 	scope, err := NewDeploymentSettingsScope(ctx, r.Client, settings)
 	if err != nil {
 		logger.Error(err, "failed to create deployment settings scope")

diff --git a/controller/internal/controller/gitrepository_controller.go b/controller/internal/controller/gitrepository_controller.go
@@ -6,7 +6,6 @@ import (
 
 	console "github.com/pluralsh/console-client-go"
 	corev1 "k8s.io/api/core/v1"
-	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
@@ -55,12 +54,9 @@ func (r *GitRepositoryReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	logger := log.FromContext(ctx)
 	repo := &v1alpha1.GitRepository{}
 	if err := r.Get(ctx, req.NamespacedName, repo); err != nil {
-		if apierrors.IsNotFound(err) {
-			return ctrl.Result{}, nil
-		}
-		return ctrl.Result{}, err
+		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkCondition(repo.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewGitRepositoryScope(ctx, r.Client, repo)
 	if err != nil {
 		logger.Error(err, "failed to create scope")

diff --git a/controller/internal/controller/globalservice_controller.go b/controller/internal/controller/globalservice_controller.go
@@ -65,6 +65,8 @@ func (r *GlobalServiceReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	if err := r.Get(ctx, req.NamespacedName, globalService); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
+
+	utils.MarkCondition(globalService.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewGlobalServiceScope(ctx, r.Client, globalService)
 	if err != nil {
 		logger.Error(err, "failed to create scope")
@@ -164,6 +166,7 @@ func (r *GlobalServiceReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 
 	globalService.Status.SHA = &sha
 	utils.MarkCondition(globalService.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionTrue, v1alpha1.SynchronizedConditionReason, "")
+	utils.MarkCondition(globalService.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 	return ctrl.Result{}, nil
 }
 

diff --git a/controller/internal/controller/globalservice_test.go b/controller/internal/controller/globalservice_test.go
@@ -149,6 +149,11 @@ var _ = Describe("Global Service Controller", Ordered, func() {
 							Reason:  v1alpha1.NamespacedCredentialsReasonDefault.String(),
 							Message: v1alpha1.NamespacedCredentialsConditionMessage.String(),
 						},
+						{
+							Type:   v1alpha1.ReadyConditionType.String(),
+							Status: metav1.ConditionFalse,
+							Reason: v1alpha1.ReadyConditionReason.String(),
+						},
 						{
 							Type:   v1alpha1.SynchronizedConditionType.String(),
 							Status: metav1.ConditionTrue,

diff --git a/controller/internal/controller/infrastructurestack_controller.go b/controller/internal/controller/infrastructurestack_controller.go
@@ -20,6 +20,9 @@ import (
 	"context"
 	"fmt"
 
+	"sigs.k8s.io/controller-runtime/pkg/builder"
+	"sigs.k8s.io/controller-runtime/pkg/predicate"
+
 	console "github.com/pluralsh/console-client-go"
 	"github.com/pluralsh/console/controller/internal/cache"
 	"github.com/pluralsh/console/controller/internal/credentials"
@@ -68,7 +71,7 @@ func (r *InfrastructureStackReconciler) Reconcile(ctx context.Context, req ctrl.
 	if err := r.Get(ctx, req.NamespacedName, stack); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkCondition(stack.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewInfrastructureStackScope(ctx, r.Client, stack)
 	if err != nil {
 		logger.Error(err, "failed to create stack")
@@ -194,6 +197,8 @@ func (r *InfrastructureStackReconciler) SetupWithManager(mgr ctrl.Manager) error
 		WithOptions(controller.Options{MaxConcurrentReconciles: 1}).                                                                 // Requirement for credentials implementation.
 		Watches(&v1alpha1.NamespaceCredentials{}, credentials.OnCredentialsChange(r.Client, new(v1alpha1.InfrastructureStackList))). // Reconcile objects on credentials change.
 		For(&v1alpha1.InfrastructureStack{}).
+		Owns(&corev1.Secret{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})).
+		Owns(&corev1.ConfigMap{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})).
 		Complete(r)
 }
 
@@ -295,6 +300,9 @@ func (r *InfrastructureStackReconciler) getStackAttributes(ctx context.Context,
 		if err := r.Get(ctx, name, secret); err != nil {
 			return nil, err
 		}
+		if err := utils.TryAddControllerRef(ctx, r.Client, stack, secret, r.Scheme); err != nil {
+			return nil, err
+		}
 		for k, v := range secret.Data {
 			attr.Files = append(attr.Files, &console.StackFileAttributes{
 				Path:    fmt.Sprintf("%s/%s", file.MountPath, k),
@@ -315,6 +323,9 @@ func (r *InfrastructureStackReconciler) getStackAttributes(ctx context.Context,
 			if err := r.Get(ctx, name, secret); err != nil {
 				return nil, err
 			}
+			if err := utils.TryAddControllerRef(ctx, r.Client, stack, secret, r.Scheme); err != nil {
+				return nil, err
+			}
 			isSecret = lo.ToPtr(true)
 			rawData, ok := secret.Data[env.SecretKeyRef.Key]
 			if !ok {
@@ -327,6 +338,9 @@ func (r *InfrastructureStackReconciler) getStackAttributes(ctx context.Context,
 			if err := r.Get(ctx, name, configMap); err != nil {
 				return nil, err
 			}
+			if err := utils.TryAddControllerRef(ctx, r.Client, stack, configMap, r.Scheme); err != nil {
+				return nil, err
+			}
 			rawData, ok := configMap.Data[env.ConfigMapRef.Key]
 			if !ok {
 				return nil, fmt.Errorf("can not find secret data for the key %s", env.ConfigMapRef.Key)

diff --git a/controller/internal/controller/managednamespace_controller.go b/controller/internal/controller/managednamespace_controller.go
@@ -66,6 +66,8 @@ func (r *ManagedNamespaceReconciler) Reconcile(ctx context.Context, req ctrl.Req
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
 
+	utils.MarkCondition(managedNamespace.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
+
 	scope, err := NewManagedNamespaceScope(ctx, r.Client, managedNamespace)
 	if err != nil {
 		logger.Error(err, "failed to create scope")

diff --git a/controller/internal/controller/namespace_credentials_controller.go b/controller/internal/controller/namespace_credentials_controller.go
@@ -47,6 +47,7 @@ func (r *NamespaceCredentialsReconciler) Reconcile(ctx context.Context, req reco
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
 
+	utils.MarkCondition(nc.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewNamespaceCredentialsScope(ctx, r.Client, nc)
 	if err != nil {
 		utils.MarkCondition(nc.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionFalse, v1alpha1.SynchronizedConditionReasonError, fmt.Sprintf("failed to create scope: %s", err.Error()))
@@ -82,7 +83,7 @@ func (r *NamespaceCredentialsReconciler) Reconcile(ctx context.Context, req reco
 	}
 
 	utils.MarkTrue(nc.SetCondition, v1alpha1.SynchronizedConditionType, v1alpha1.SynchronizedConditionReason, "")
-
+	utils.MarkCondition(nc.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 	return requeue, nil
 }
 

diff --git a/controller/internal/controller/notificationrouter_controller.go b/controller/internal/controller/notificationrouter_controller.go
@@ -64,6 +64,8 @@ func (r *NotificationRouterReconciler) Reconcile(ctx context.Context, req ctrl.R
 	if err := r.Get(ctx, req.NamespacedName, notificationRouter); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
+
+	utils.MarkCondition(notificationRouter.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewNotificationRouterScope(ctx, r.Client, notificationRouter)
 	if err != nil {
 		logger.Error(err, "failed to create scope")

diff --git a/controller/internal/controller/notificationsink_controller.go b/controller/internal/controller/notificationsink_controller.go
@@ -64,6 +64,9 @@ func (r *NotificationSinkReconciler) Reconcile(ctx context.Context, req ctrl.Req
 	if err := r.Get(ctx, req.NamespacedName, notificationSink); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
+
+	utils.MarkCondition(notificationSink.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
+
 	scope, err := NewNotificationSinkScope(ctx, r.Client, notificationSink)
 	if err != nil {
 		logger.Error(err, "failed to create scope")
@@ -163,6 +166,7 @@ func (r *NotificationSinkReconciler) handleExisting(ctx context.Context, notific
 	}
 	notificationSink.Status.ID = &existing.ID
 	utils.MarkCondition(notificationSink.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionTrue, v1alpha1.SynchronizedConditionReason, "")
+	utils.MarkCondition(notificationSink.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 
 	return requeue, nil
 }

diff --git a/controller/internal/controller/pipeline_controller.go b/controller/internal/controller/pipeline_controller.go
@@ -66,7 +66,7 @@ func (r *PipelineReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_
 		logger.Error(err, "Unable to fetch pipeline")
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkCondition(pipeline.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	// Ensure that status updates will always be persisted when exiting this function.
 	scope, err := NewPipelineScope(ctx, r.Client, pipeline)
 	if err != nil {
@@ -137,7 +137,7 @@ func (r *PipelineReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_
 	pipeline.Status.ID = &apiPipeline.ID
 	pipeline.Status.SHA = &sha
 	utils.MarkCondition(pipeline.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionTrue, v1alpha1.SynchronizedConditionReason, "")
-
+	utils.MarkCondition(pipeline.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 	return requeue, nil
 }
 

diff --git a/controller/internal/controller/pipeline_controller_test.go b/controller/internal/controller/pipeline_controller_test.go
@@ -253,6 +253,12 @@ var _ = Describe("Pipeline Controller", Ordered, func() {
 						Reason:  v1alpha1.NamespacedCredentialsReasonDefault.String(),
 						Message: v1alpha1.NamespacedCredentialsConditionMessage.String(),
 					},
+					{
+						Type:    v1alpha1.ReadyConditionType.String(),
+						Status:  metav1.ConditionTrue,
+						Reason:  v1alpha1.ReadyConditionReason.String(),
+						Message: "",
+					},
 					{
 						Type:   v1alpha1.SynchronizedConditionType.String(),
 						Status: metav1.ConditionTrue,
@@ -297,6 +303,12 @@ var _ = Describe("Pipeline Controller", Ordered, func() {
 						Reason:  v1alpha1.NamespacedCredentialsReasonDefault.String(),
 						Message: v1alpha1.NamespacedCredentialsConditionMessage.String(),
 					},
+					{
+						Type:    v1alpha1.ReadyConditionType.String(),
+						Status:  metav1.ConditionTrue,
+						Reason:  v1alpha1.ReadyConditionReason.String(),
+						Message: "",
+					},
 					{
 						Type:   v1alpha1.SynchronizedConditionType.String(),
 						Status: metav1.ConditionTrue,

diff --git a/controller/internal/controller/pipelinecontext_controller.go b/controller/internal/controller/pipelinecontext_controller.go
@@ -61,7 +61,7 @@ func (r *PipelineContextReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 	if err := r.Get(ctx, req.NamespacedName, pipelineContext); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkCondition(pipelineContext.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 	pipeline := &v1alpha1.Pipeline{}
 	if err := r.Get(ctx, client.ObjectKey{Name: pipelineContext.Spec.PipelineRef.Name, Namespace: pipelineContext.Spec.PipelineRef.Namespace}, pipeline); err != nil {
 		utils.MarkCondition(pipelineContext.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionFalse, v1alpha1.SynchronizedConditionReasonError, err.Error())
@@ -80,7 +80,6 @@ func (r *PipelineContextReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 	if err := utils.TryAddControllerRef(ctx, r.Client, pipeline, pipelineContext, r.Scheme); err != nil {
 		return ctrl.Result{}, err
 	}
-
 	scope, err := NewPipelineContextScope(ctx, r.Client, pipelineContext)
 	if err != nil {
 		utils.MarkFalse(pipelineContext.SetCondition, v1alpha1.SynchronizedConditionType, v1alpha1.SynchronizedConditionReasonError, err.Error())

diff --git a/controller/internal/controller/prautomation_controller.go b/controller/internal/controller/prautomation_controller.go
@@ -48,7 +48,7 @@ func (in *PrAutomationReconciler) Reconcile(ctx context.Context, req reconcile.R
 	if err := in.Get(ctx, req.NamespacedName, prAutomation); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-
+	utils.MarkFalse(prAutomation.SetCondition, v1alpha1.ReadyConditionType, v1alpha1.ReadyConditionReason, "")
 	scope, err := NewPrAutomationScope(ctx, in.Client, prAutomation)
 	if err != nil {
 		utils.MarkFalse(prAutomation.SetCondition, v1alpha1.SynchronizedConditionType, v1alpha1.SynchronizedConditionReasonError, err.Error())
@@ -96,6 +96,7 @@ func (in *PrAutomationReconciler) Reconcile(ctx context.Context, req reconcile.R
 
 	in.updateReadyCondition(prAutomation)
 	utils.MarkTrue(prAutomation.SetCondition, v1alpha1.SynchronizedConditionType, v1alpha1.SynchronizedConditionReason, "")
+	utils.MarkTrue(prAutomation.SetCondition, v1alpha1.ReadyConditionType, v1alpha1.ReadyConditionReason, "")
 
 	return requeue, nil
 }

diff --git a/controller/internal/controller/prautomationtrigger_controller.go b/controller/internal/controller/prautomationtrigger_controller.go
@@ -59,6 +59,7 @@ func (r *PrAutomationTriggerReconciler) Reconcile(ctx context.Context, req ctrl.
 	if err := r.Get(ctx, req.NamespacedName, trigger); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
+	utils.MarkCondition(trigger.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 
 	prAutomation := &v1alpha1.PrAutomation{}
 	if err := r.Get(ctx, client.ObjectKey{Name: trigger.Spec.PrAutomationRef.Name, Namespace: trigger.Spec.PrAutomationRef.Namespace}, prAutomation); err != nil {

diff --git a/controller/internal/controller/project_controller.go b/controller/internal/controller/project_controller.go
@@ -53,6 +53,7 @@ func (in *ProjectReconciler) Reconcile(ctx context.Context, req reconcile.Reques
 	if err := in.Get(ctx, req.NamespacedName, project); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
+	utils.MarkCondition(project.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionFalse, v1alpha1.ReadyConditionReason, "")
 
 	scope, err := NewProjectScope(ctx, in.Client, project)
 	if err != nil {
@@ -189,7 +190,7 @@ func (in *ProjectReconciler) handleExistingProject(ctx context.Context, project
 	project.Status.ID = &apiProject.ID
 
 	utils.MarkCondition(project.SetCondition, v1alpha1.SynchronizedConditionType, v1.ConditionTrue, v1alpha1.SynchronizedConditionReason, "")
-	// utils.MarkCondition(project.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
+	utils.MarkCondition(project.SetCondition, v1alpha1.ReadyConditionType, v1.ConditionTrue, v1alpha1.ReadyConditionReason, "")
 
 	return requeue, nil
 }