Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detach in crd typing #916

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix detach in crd typing #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/controller/crds/deployments.plural.sh_globalservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion charts/controller/crds/deployments.plural.sh_managednamespaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion controller/api/v1alpha1/globalservice_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func init() {
type Cascade struct {
// Whether you want to delete owned resources in Plural but leave kubernetes objects in-place
// +kubebuilder:validation:Optional
Detach *bool `json:"detach.omitempty"`
Detach *bool `json:"detach,omitempty"`

// Whether you want to delete owned resources in Plural and in the targeted k8s cluster
// +kubebuilder:validation:Optional
Expand Down
2 changes: 1 addition & 1 deletion controller/config/crd/bases/deployments.plural.sh_globalservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion controller/config/crd/bases/deployments.plural.sh_managednamespaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion controller/docs/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ _Appears in:_

| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `detach.omitempty` _boolean_ | Whether you want to delete owned resources in Plural but leave kubernetes objects in-place | | Optional: {} <br /> |
| `detach` _boolean_ | Whether you want to delete owned resources in Plural but leave kubernetes objects in-place | | Optional: {} <br /> |
| `delete` _boolean_ | Whether you want to delete owned resources in Plural and in the targeted k8s cluster | | Optional: {} <br /> |


Expand Down
2 changes: 1 addition & 1 deletion plural/helm/console/crds/deployments.plural.sh_globalservices.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion plural/helm/console/crds/deployments.plural.sh_managednamespaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: Whether you want to delete owned resources in Plural
and in the targeted k8s cluster
type: boolean
detach.omitempty:
detach:
description: Whether you want to delete owned resources in Plural
but leave kubernetes objects in-place
type: boolean
Expand Down
Loading