Handle byok clusters slightly better #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usecase here is: * user creates cluster CRD for byok cluster prior to installing agent * CRD should retry until agent is there then reconcile successfully
|
Visit the preview URL for this PR (updated for commit 59086e6): https://pluralsh-console--pr949-mjg-eng-2060-cluster-ae0hq2hf.web.app (expires Fri, 17 May 2024 15:52:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
seemywingz
approved these changes
May 10, 2024
| @@ -295,18 +295,20 @@ var _ = Describe("Cluster Controller", Ordered, func() { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| Expect(sanitizeClusterStatus(cluster.Status)).To(Equal(sanitizeClusterStatus(v1alpha1.ClusterStatus{ | |||
| Status: v1alpha1.Status{ | |||
| ID: lo.ToPtr(byokClusterConsoleID), | |||
| SHA: lo.ToPtr("CPYLCGRGF2JWFBF3OGRHQQUSBDXW6Y4VMUDQDCQQDEA6G6CAZORQ===="), | |||
| // ID: lo.ToPtr(byokClusterConsoleID), | |||
There was a problem hiding this comment.
Could you tell me what the policy is for committing commented code?
Is this for reference or testing?
I think I'm still a bit traumatized from Amazon code reviews 😬
There was a problem hiding this comment.
There's no real policy, I commented it out because i wasn't sure whether i needed to revert
zreigz
approved these changes
May 10, 2024
michaeljguarino
deleted the
mjg/eng-2060-cluster-crd-should-retry-to-find-non-existing-clusters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usecase here is:
Test Plan
n/a
Checklist