Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?]: CircularProgress does not allow value of 0 #2051

Closed
2 tasks done
caseybaggz opened this issue Dec 17, 2021 · 0 comments · Fixed by #2058
Closed
2 tasks done

[Bug?]: CircularProgress does not allow value of 0 #2051

caseybaggz opened this issue Dec 17, 2021 · 0 comments · Fixed by #2058
Assignees
@Rykus0
Labels
bug Something isn't working

Comments

@caseybaggz
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Due to the math being used in the component a value of 0 will incorrectly show a progress of ~25%.

Expected behavior 🤔

Progress should allow a value prop of 0 and follow the a11y guidelines for a progress bar:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_progressbar_role

Steps to reproduce 🕹

Steps:

  1. Open codesandbox example from docs
  2. Add value 0 to static progress

Context 🔦

Skills are using this component to display the progress of a course - via "@Meg" / Meghan Kline-Tuls

Your environment 🌎

No response
@caseybaggz caseybaggz added the bug Something isn't working label Dec 17, 2021
@Rykus0 Rykus0 self-assigned this Jan 14, 2022
Rykus0 added a commit that referenced this issue Jan 18, 2022
@Rykus0
fix(circularprogress): #2051 - add pkg run script
e8e0198
Rykus0 added a commit that referenced this issue Jan 18, 2022
@Rykus0
fix(circularprogress): fixes #2051 - allow zero
e999955
@Rykus0 Rykus0 mentioned this issue Jan 18, 2022
Merged
10 tasks
@Rykus0 Rykus0 linked a pull request Jan 19, 2022 that will close this issue
Fix/2051/circular progress zero #2058
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rykus0 Rykus0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/2051/circular progress zero pluralsight/classic-design-system
2 participants
@Rykus0 @caseybaggz