Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to master branch if branched guide is missing #50

Closed
durden opened this issue Apr 22, 2016 · 0 comments
Closed

Redirect to master branch if branched guide is missing #50

durden opened this issue Apr 22, 2016 · 0 comments

Comments

@durden
Copy link
Contributor

durden commented Apr 22, 2016

Currently we return 404 for a guide URL that includes a branch and the branch was removed. This makes sense because we technically couldn't find that guide. However, it would be more useful to redirect to the master branch of that guide with a flash message or something noting that the branch no longer exists.

For example, going to http://tutorials.pluralsight.com/ruby-ruby-on-rails/using-https-with-ruby-on-rails?branch=prtkgpt will return 404 and redirect to the homepage. This guide has since been published and all branches were integrated and removed. Therefore, the prtkgpt user's changes were either accepted or rejected. We could redirect this request to the canonical version of the guide with a message mentioning that.

@durden durden closed this as completed in 224b812 May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant