Puntzak! a plusfries widget #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietvanzoen
reviewed
Dec 14, 2018
| "lint": "eslint .", | ||
| "fmt": "prettier --no-color --write '**/*.{md,js}'", | ||
| "preinstall": "cp -n .env.example .env", | ||
| "preinstall": "test -f .env || cp -n .env.example .env", |
There was a problem hiding this comment.
the -n flag should be --no-clobber. was this not the case on your end?
There was a problem hiding this comment.
without the check
$ cp -n .env.example .env
error Command failed with exit code 1.
There was a problem hiding this comment.
when i run yarn install
There was a problem hiding this comment.
Hm...
-n, --no-clobber
do not overwrite an existing file (overrides a previous -i option)
there should be a flag like this. mind checking your man cp. maybe it's a little different? if not we can just do the test
There was a problem hiding this comment.
yep, it's there. might be because it writes to stdout?
❯ cp -n .env.example .env
.env not overwritten
keepitterron
commented
Dec 14, 2018
| # Compress and minify widget | ||
| set -e | ||
|
|
||
| TEMP_DIR="$(mktemp -d)" |
There was a problem hiding this comment.
uuuuuuuu didn't know about that 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to get this out of the door.
The build pipeline is a bit meh, can be better. much better.
feel free to commit to this branch 🍟