Skip to content

Commit

Permalink
#51: Exclude not resolved challenges in TravisCI
Browse files Browse the repository at this point in the history
  • Loading branch information
plutov committed Sep 12, 2018
1 parent fa4570a commit 2c4ebe4
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 9 deletions.
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#### Is your solution the most efficient way to solve a problem? Why?
#### Have you used any specific algorithm?
#### What is time and space complexity of your solution?
20 changes: 12 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
### Go exercises and elegant solutions
## Go coding exercises and elegant solutions [![Build Status](https://travis-ci.org/plutov/practice-go.svg?branch=master)](https://travis-ci.org/plutov/practice-go)

### How to solve

- Each folder has a README.md file and `*_test.go` file, check it and find what kind of function you need to implement.
- You may use anything you want except 3rd-party packages.
- Implement the function and uncomment line with `t.Errorf()` in `*_test.go` file.
- Run tests and benchmarks.
- Create a PR to `master` branch and answer questions from PR template.
- We will choose the most fast and elegant solution and merge into the repo within 7 days.

### Challenges

- [x] ([@macocha](https://github.com/macocha)) [chess](https://github.com/plutov/practice-go/tree/master/chess)
- [x] ([@kennygrant](https://github.com/kennygrant)) [floyd](https://github.com/plutov/practice-go/tree/master/floyd)
Expand All @@ -20,13 +31,6 @@
- [x] ([@TomLefley](https://github.com/TomLefley)) [warriors](https://github.com/plutov/practice-go/tree/master/warriors)
- [ ] (not solved) [snowflakes](https://github.com/plutov/practice-go/tree/master/snowflakes)

### How to solve

- Each folder has a README.md file and _test.go file, check it and find what kind of function you need to implement.
- Code this function in the separate .go file inside a package and run tests. You may use anything you want except 3rd-party packages.
- Create a PR with one .go file.
- We will choose the most fast and elegant solution and merge into the repo within 7 days.

### Run tests with benchmarks

Run it in the challenge folder:
Expand Down
3 changes: 2 additions & 1 deletion snowflakes/snowflakes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ func TestOverlaidTriangles(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
got := OverlaidTriangles(tt.n, tt.m)
if got != tt.want {
t.Errorf("OverlaidTriangles(%d, %d) got %d, want %d", tt.n, tt.m, got, tt.want)
// TODO: uncomment after implementation
//t.Errorf("OverlaidTriangles(%d, %d) got %d, want %d", tt.n, tt.m, got, tt.want)
}
})
}
Expand Down

0 comments on commit 2c4ebe4

Please sign in to comment.