Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing dark/ bright #27

Closed
3 tasks done
theimo1221 opened this issue Feb 17, 2018 · 5 comments
Closed
3 tasks done

Changing dark/ bright #27

theimo1221 opened this issue Feb 17, 2018 · 5 comments

Comments

@theimo1221
Copy link
Contributor

theimo1221 commented Feb 17, 2018

Hello,

what do you guys think about changing current dark/ bright to an algorithm based color.

This way you could see a difference between 1, 4, 6 and 100 unique Orders.

Currently 1=4 and 6=100.

Additionally if we touch this, we should think about making it readable for people with red-green issue

Thanks and Greets

Theimo

Edit: Needed Tasks

  • create a button that changes the color coding to something that red/green color-blind people can use
  • implemented color based on unique orders in Major visual changes  #37
  • discuss continuous dark/ bright vs slider with border
@pmaji
Copy link
Owner

pmaji commented Feb 17, 2018

Hmm I know you closed this but it's an interesting idea @theimo1221, although I would take it a bit differently. Here's what I think.

I want to have a slider of sorts (I think this would be a Plotly callback) with which the user can control the parameter that changes the coloring. I.e. the default is 5, but they can change it to 10 which would then make it so that only price points with 10 or more unique orders are colored with the bright red / bright green.

@pmaji
Copy link
Owner

pmaji commented Feb 17, 2018

  • create a button that changes the color coding to something that red/green color-blind people can use
  • create a slider or other input method by which users can control what number of orders they want to color-sort by (this would need to be something that is distinct for EACH currency pair.

@theimo1221 adding these next steps for this issue.

@theimo1221
Copy link
Contributor Author

It´s not closed, I just referenced this from a closed issue.

I partly disagree with the slider. We have to consider how much influence the visitor has on the Dash App, cause he changes data/ settings for other users as well, if it´s hosted from us.

@theimo1221
Copy link
Contributor Author

theimo1221 commented Feb 18, 2018

In #37 I added the color based on unique orders and inverted dark/ bright to highlight the "bad boys"
If you are comfortable with changes in #37 you can close this issue after merge.

Some comparision (it´s not the exact same time)
Previous:
image

Currently:
image

In my opinion the changes highly increases visibility and readability

@theimo1221
Copy link
Contributor Author

Closed cause of #41 was approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants