-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major visual changes #37
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current size was just the root of volume. In BTC-EUR currently the biggest volume is 14, wich results in invisible bubbles. I changed it, that now the biggest bubble will always be at size 32. All other bubble sizes are multiplied with same factor. It´s tested and looks good.
theimo1221
changed the title
Fixed Bubble Size for low volume pairs
Visual changes for low volume pairs
Feb 18, 2018
With Logscale the minor range can be viewed more easily. With Volume filter all sumups less than 1% of Total Volume are filtered. Asfaik This is to track Whales
Additionally this reduces callback load from 18Kb to 5.3 Kb for 8 pairs. |
It uses panda.apply to calculate the correct rgb and adds it as a string
theimo1221
added a commit
to theimo1221/eth_python_tracker
that referenced
this pull request
Feb 18, 2018
Closed cause of #41 was approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current size was just the root of volume.
In BTC-EUR currently the biggest volume is 14, wich results in invisible bubbles.
I changed it, that now the biggest bubble will always be at size 32.
All other bubble sizes are multiplied with same factor.
It´s tested and looks good.