Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by volume additionally #42

Closed
4 tasks done
theimo1221 opened this issue Feb 18, 2018 · 4 comments
Closed
4 tasks done

Group by volume additionally #42

theimo1221 opened this issue Feb 18, 2018 · 4 comments

Comments

@theimo1221
Copy link
Contributor

theimo1221 commented Feb 18, 2018

Had a nice and good discussion with Paul. We found many good and some little points.

Pull #41 did a lot of changes towards original goal of detecting whales and fake Resistances/ Supports.

Currrently we spot fakes by grouping price.
An additional approach would be grouping by volume (e.g. 50 orders of 1.53 ETH from $962.65 to $984.42.

At current state we thing adding a bar at the position of summed up volume with the bot beeing at the start and top beeing at the end of price range could be best.

Needed steps to do this:

  • Calculate new dataset
  • Grouping dataset
  • adding go.bar or rectangle
  • needs description in legend
    I guess go.bar won´t work cause we start at different y-levels
@pmaji
Copy link
Owner

pmaji commented Feb 19, 2018

Definitely something worth exploring. Lower on the priority list but still an interesting possibility worth of future iteration.

theimo1221 added a commit to theimo1221/eth_python_tracker that referenced this issue Feb 19, 2018
I guess this completes pmaji#42
It is tested and works.
@theimo1221
Copy link
Contributor Author

theimo1221 commented Feb 19, 2018

If #49 get´s pulled and legend is updated (@pmaji ) this can be closed

@pmaji
Copy link
Owner

pmaji commented Feb 19, 2018

All good to go. This addition is massively helpful @theimo1221. I'll do a re-write of the README tonight because this changes a lot.

@pmaji
Copy link
Owner

pmaji commented Feb 20, 2018

Integrated new information into README; marking issue as completed (just need to add documentation via extensive comments now).

@pmaji pmaji closed this as completed Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants