Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction to one callback (All pairs) #40

Closed
wants to merge 4 commits into from

Conversation

theimo1221
Copy link
Contributor

After long trial and error I found a way to reduce callback and requests to server to 1 regardless of pair amount.

It also reduces Package Amount to 16 Kb (avg. 4kb per Pair) to before 5Kb per pair.

Includes #39

After long trial and error I found a way to reduce callback and requests to server to 1 regardless of pair amount.

It also reduces Package Amount to 16 Kb (avg. 4kb per Pair) to before 5Kb per pair.

Includes pmaji#39
If Graph is already hidden text was wrong.
@theimo1221
Copy link
Contributor Author

Feature is clompletly tested and should work without any problems

Added correct caching for prepared html data, to reduce load on server.

Now every request just gets the cached data -> no further computation in callback
@theimo1221
Copy link
Contributor Author

theimo1221 commented Feb 18, 2018

Reduces Load Size even more than predicted for multiple Pairs Screenshot of 8 pairs:
Every line is 4s after previous
image

Data gets pasted with first update anyways.
So no need to have duplicate code and empty graphs at beginning
@theimo1221
Copy link
Contributor Author

Added reduced inital load.

@theimo1221 theimo1221 mentioned this pull request Feb 18, 2018
@theimo1221
Copy link
Contributor Author

Combined with #37 Load reduced to 5.3 Kb for 8 pairs.

Before changes we had 5.8Kb per Pair 👍

@theimo1221 theimo1221 mentioned this pull request Feb 18, 2018
@theimo1221
Copy link
Contributor Author

Would be interesting to see, if problem described in #16 is solved by this.

theimo1221 added a commit to theimo1221/eth_python_tracker that referenced this pull request Feb 18, 2018
@theimo1221 theimo1221 mentioned this pull request Feb 18, 2018
5 tasks
@theimo1221
Copy link
Contributor Author

Is in #41
@pmaji If you are okay with #41 you can simply close this

@theimo1221
Copy link
Contributor Author

Closed cause of #41 was approved

@theimo1221 theimo1221 closed this Feb 18, 2018
@theimo1221 theimo1221 deleted the patch-22 branch February 19, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant