Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #66

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Some improvements #66

merged 2 commits into from
Feb 24, 2018

Conversation

mifunetoshiro
Copy link
Contributor

Replaces current #60 pull request

Replaces current #60 pull request
@mifunetoshiro
Copy link
Contributor Author

mifunetoshiro commented Feb 23, 2018

By the way, is there any particular reason why the run_server host IP is 0.0.0.0 and not 127.0.0.1? Do I change it back? Because by default it would tell me the server is running on 0.0.0.0:8050, which is inaccessible and couldn't connect to.

@theimo1221
Copy link
Contributor

theimo1221 commented Feb 23, 2018

@mifunetoshiro
Copy link
Contributor Author

Ok, changed back to 0.0.0.0. Was just confusing to me because the app said it was running on 0.0.0.0, which I couldn't connect to.

@theimo1221
Copy link
Contributor

theimo1221 commented Feb 23, 2018

Yes, for your PC it is running on 0.0.0.0 but to connect to it usually you need to visit http://127.0.0.1:8050 or http://localhost:8050

Thnaks for your changes

Copy link
Owner

@pmaji pmaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improves rounding methodology to cover wider scope. Also converts order number to int in order to drop unnecessary decimals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants