New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenAPI reusable responses in global components object (handle $ref properly everywhere) #852
Conversation
… coder for an individual response
…other script (because the requirment is a $ref) up to Coder / TypeCoder
|
Pull Request Test Coverage Report for Build 8697996524Details
💛 - Coveralls |
// eslint-disable-next-line no-param-reassign | ||
script.comments = READ_ONLY_COMMENTS; | ||
|
||
const xType = script.importSharedType("WideOperationArgument"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using an enum
instead of hard coded strings:
const xType = script.importSharedType("WideOperationArgument"); | |
const xType = script.importSharedType(SharedType.WideOperationArgument); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings appear as both a type name and a runtime value. I don't think there's a way to share across those two different contexts. Otherwise good idea.
|
||
const xType = script.importSharedType("WideOperationArgument"); | ||
|
||
script.importSharedType("OmitValueWhenNever"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. Likely these types won't ever change, but it seems more future-proof.
a15a909
to
b4b6903
Compare
remove dead (copy/pasted) code
b4b6903
to
fc3e1ef
Compare
This should fix #838.