Ignore changes to test code of PMD when generating dynamic rule sets #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adangel
approved these changes
Aug 6, 2018
adangel
changed the title
adangel
added a commit
that referenced
this pull request
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of pmdtester in pmd/pmd#1280 is not expected. The dynamic rule set of the patch branch should only contain the bestpratices rule set instead of the all java rules.
In addition, danger should comment that no java rules are changed in pmd/pmd#1282 rather than provide the diff report link. The above issues are caused by not filtering the test code of pmd when generating the dynamic rule set. Please help me check if I still have something left 😄