Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Merging Javacc build scripts #2239

Closed
22 tasks done
oowekyala opened this issue Jan 18, 2020 · 3 comments
Closed
22 tasks done

[core] Merging Javacc build scripts #2239

oowekyala opened this issue Jan 18, 2020 · 3 comments
Labels
in:pmd-internals Affects PMD's internals
Projects
Milestone

Comments

@oowekyala
Copy link
Member

oowekyala commented Jan 18, 2020

TODO on master

TODO on 7.0

Should we really consider *TokenKinds a published API? Since token kinds are compile-time constants, adding or removing tokens in the grammar may break binary compatibility implicitly.

Remaining tasks

@oowekyala
Copy link
Member Author

oowekyala commented Mar 17, 2020

Note: on master the visitor interfaces generated by Javacc are deprecated, but shouldn't be (eg JavaParserVisitor) (fixed by e1069b4)

@adangel
Copy link
Member

adangel commented Mar 19, 2020

I'll try to port PLSQL now....

@oowekyala
Copy link
Member Author

I think this can is done now. The only remaining thing is #4065

PMD 7 automation moved this from In progress to Done Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
No open projects
PMD 7
  
Done
Development

No branches or pull requests

2 participants