Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer #4065

Closed
Tracked by #3898
oowekyala opened this issue Jul 26, 2022 · 0 comments · Fixed by #4797
Closed
Tracked by #3898

[core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer #4065

oowekyala opened this issue Jul 26, 2022 · 0 comments · Fixed by #4797
Labels
in:cpd Affects the copy-paste detector in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

oowekyala commented Jul 26, 2022 •
edited by adangel
Loading

and Tokenizer to CpdLexer, to have symmetry

Reasoning: rename to something not javacc specific (eg LexException/ScanException)
LexException, then Tokenizer -> CpdLexer
@oowekyala oowekyala mentioned this issue Jul 26, 2022
Closed
22 tasks
@oowekyala oowekyala changed the title maybe rename to something not javacc specific (eg LexException/ScanException) [core] Rename TokenMgrError to LexException Jul 26, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Jul 27, 2022
@adangel adangel added the in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception label Jan 13, 2023
@adangel adangel mentioned this issue Jan 23, 2023
Closed
55 tasks
@adangel adangel added the in:cpd Affects the copy-paste detector label Jan 11, 2024
@adangel adangel changed the title [core] Rename TokenMgrError to LexException [core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer Jan 11, 2024
adangel added a commit to adangel/pmd that referenced this issue Jan 11, 2024
@adangel
[core] Rename TokenMgrError to LexException
55d9179 
See pmd#4065
adangel added a commit to adangel/pmd that referenced this issue Jan 11, 2024
@adangel
[core] Rename Tokenizer to CpdLexer
6163f67 
See pmd#4065
adangel added a commit to adangel/pmd that referenced this issue Jan 11, 2024
@adangel
[doc] Update release notes (pmd#4065)
bd93346
@adangel adangel mentioned this issue Jan 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:cpd Affects the copy-paste detector in:grammar About the grammar of a lexer or parser, eg, a parse/lex exception
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer adangel/pmd
2 participants
@adangel @oowekyala