Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Consolidate n.s.pmd.lang.rule package #3917

Closed
Tracked by #3898
oowekyala opened this issue Apr 15, 2022 · 0 comments · Fixed by #4799
Closed
Tracked by #3898

[core] Consolidate n.s.pmd.lang.rule package #3917

oowekyala opened this issue Apr 15, 2022 · 0 comments · Fixed by #4799
Assignees
@adangel
Labels
an:enhancement An improvement on existing features / rules
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

oowekyala commented Apr 15, 2022 •
edited
Loading

We should move Rule, Ruleset and related classes into nspmd.lang.rule.

Types that could also be moved there include:

  • Rule
  • RuleSetFactory (package private)
  • nspmd.rules.RuleFactory (package private)
  • RuleSetFactoryCompatibility (package private)
  • RuleSetLoader
  • RuleSet
  • RuleSets
  • RulePriority
  • RuleSetLoadException
  • RuleSetWriter
  • RuleSetReferenceId

The purpose of this is to clean up the root nspmd package which is currently a mess.

(Part of #3916)
@oowekyala oowekyala added the an:enhancement An improvement on existing features / rules label Apr 15, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Apr 15, 2022
@oowekyala oowekyala mentioned this issue Apr 15, 2022
Closed
@adangel adangel mentioned this issue Jan 23, 2023
Closed
55 tasks
@adangel adangel self-assigned this Jan 12, 2024
@adangel adangel changed the title [core] Consolidate nspmd.lang.rule package [core] Consolidate n.s.pmd.lang.rule package Jan 12, 2024
adangel added a commit to adangel/pmd that referenced this issue Jan 13, 2024
@adangel
[core] Move Rule/RuleSet related type into net.sourceforge.pmd.rule
9e668c2 
Refs pmd#3917
adangel added a commit to adangel/pmd that referenced this issue Jan 13, 2024
@adangel
[doc] Update release notes (pmd#3917)
7b680ee
@adangel adangel mentioned this issue Jan 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adangel adangel

Labels
an:enhancement An improvement on existing features / rules
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[core] Consolidate n.s.pmd.lang.rule package adangel/pmd
2 participants
@adangel @oowekyala