[xml] Unimplement org.w3c.dom.Node from the XmlNodeWrapper #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to help extend the Node interface later on. This class' implementing both interfaces helped nothing but would certainly have caused conflicts wrt method names and incompatible return types. For example, adding a method `Node getFirstChild()` to our Node interface would have conflicted with the getFirstChild of the w3c interface.
Generated by 🚫 Danger |
jsotuyod
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help extend the Node interface later on. The class' implementing both interfaces helped nothing, but would certainly have caused conflicts wrt method names and incompatible return types.
For example, adding a method
Node getFirstChild()to our Node interface would have conflicted with the getFirstChild of the w3c interface, because of the return type.This PR also removes AttributeNode, and puts the implementation classes of the xml AST in an internal package