Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plsql] xmlforest with optional AS #2353

Merged
merged 2 commits into from Mar 14, 2020
Merged

Conversation

szymanp23
Copy link
Contributor

Before submitting a PR, please check that:

  • The PR is submitted against master. The PMD team will merge back to support branches as needed.
  • ./mvnw clean verify passes. This will build and test PMD, execute PMD and checkstyle rules. Check this for more info

PR Description:
In reference to comment.
It looks like there is a mistake in Oracle doc, because code compiles and works both with and without AS (on Oracle 12c).
For example
SELECT XMLELEMENT("Emp", XMLFOREST(e.dummy AS foo, e.dummy last_name)) "Emp Element" FROM dual e;
I modified parser and test case.

@pmd-test
Copy link

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@adangel adangel added this to the 6.23.0 milestone Mar 14, 2020
@adangel
Copy link
Member

adangel commented Mar 14, 2020

btw - you should add your email address (you're using in the git commits) to github, because github right now still regonizes you as "first-time contributor"...

adangel added a commit that referenced this pull request Mar 14, 2020
@adangel adangel merged commit ee9f821 into pmd:master Mar 14, 2020
@szymanp23 szymanp23 deleted the xmlforest branch May 18, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants