Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c#] Fix CPD suppression with comments doesn't work #2551 #2567

Merged
merged 2 commits into from
Jun 12, 2020
Merged

[c#] Fix CPD suppression with comments doesn't work #2551 #2567

merged 2 commits into from
Jun 12, 2020

Conversation

LixonLookose
Copy link
Contributor

@LixonLookose LixonLookose commented Jun 4, 2020 •
edited
Loading

CPD Suppressions for c# fixed
test added

Describe the PR

CPD suppression with comments CPD-OFF/CPD-ON doesn't work for c#

Related issues

[c#] CPD suppression with comments doesn't work #2551

Ready?

  • Added unit tests for fixed bug/feature - Yes
  • Passing all unit tests - Yes
  • Complete build ./mvnw clean verify passes (checked automatically by travis) - Yes
  • Added (in-code) documentation (if needed) - No

@LixonLookose
[c#] CPD suppression with comments doesn't work pmd#2551
c7c31be 
CPD Suppressions for c# fixed
test added
@pmd-test
Copy link

pmd-test commented Jun 4, 2020 •
edited
Loading

1 Message
📖 This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel self-assigned this Jun 5, 2020
@adangel adangel added this to the 6.25.0 milestone Jun 5, 2020
adangel
adangel requested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

Would you mind to update the documentation as well?
In https://github.com/pmd/pmd/blob/master/docs/pages/pmd/userdocs/cpd/cpd.md we should add "C#" to the list of languages, that support suppression that way.

@LixonLookose LixonLookose marked this pull request as draft June 5, 2020 12:55
@LixonLookose
Updated documentation pmd#2551
e2a5264 
Updated cpd.md with "C#" to the list of languages, that support suppression.
@LixonLookose LixonLookose marked this pull request as ready for review June 5, 2020 13:03
@LixonLookose
Copy link
Contributor Author

@adangel Thank you for reviewing it!

@LixonLookose LixonLookose requested a review from adangel June 9, 2020 17:32
adangel
adangel approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@adangel adangel changed the title [c#] CPD suppression with comments doesn't work #2551 [c#] Fix CPD suppression with comments doesn't work #2551 Jun 12, 2020
@adangel adangel merged commit e2a5264 into pmd:master Jun 12, 2020
adangel added a commit that referenced this pull request Jun 12, 2020
@adangel
[doc] Update release notes, fixes #2551, refs #2567
30ec282
adangel added a commit that referenced this pull request Jun 12, 2020
@adangel
Merge branch 'pr-2567'
28ea13e 
[c#] Fix CPD suppression with comments doesn't work #2551 #2567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels
None yet
Projects
None yet
Milestone
6.25.0
Development

Successfully merging this pull request may close these issues.

[c#] CPD suppression with comments doesn't work
3 participants
@LixonLookose @pmd-test @adangel