Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] Update Rhino library #2906

Closed
wants to merge 1 commit into from

Conversation

adangel
Copy link
Member

@adangel adangel commented Nov 6, 2020

This uses the currently latest version 1.7.13.

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

This uses the currently latest version 1.7.13.
@oowekyala
Copy link
Member

Could we schedule this for a pmd 6 version? It's a breaking change only indirectly, so I think only few clients would be broken (if any). And it would help with eg #2081

@adangel
Copy link
Member Author

adangel commented Apr 29, 2021

Replaced by #3242

@adangel adangel closed this Apr 29, 2021
@adangel adangel removed this from the 6.35.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[javascript] Update Rhino library to 1.7.13
2 participants