Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] Update Rhino library to 1.7.13 #3242

Merged
merged 4 commits into from
May 21, 2021

Conversation

adangel
Copy link
Member

@adangel adangel commented Apr 29, 2021

This PR replaces the older #2906

Note: This introduces some incompatibility: From now on, at least Java 8 is required to analyze JavaScript code.
We did a similar upgrade with VisualForce in 6.30.0.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 6.35.0 milestone Apr 29, 2021
@pmd-test
Copy link

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

Copy link
Member

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll keep this pr as a reference of what to update when a module changes minimum java version.

docs/pages/release_notes.md Outdated Show resolved Hide resolved
docs/pages/release_notes.md Outdated Show resolved Hide resolved
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
@adangel adangel merged commit 12ec6d6 into pmd:master May 21, 2021
@adangel adangel deleted the issue-699-upgrade-rhino-java8 branch May 21, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants