[java] Update rule AvoidDuplicateLiterals

[adangel]

Part of #2701

[pmd-test]

	2 Messages
📖	Compared to pmd/7.0.x: This changeset changes 0 violations, introduces 6751 new violations, 0 new errors and 0 new configuration errors, removes 0 violations, 0 errors and 0 configuration errors. Full report
📖	Compared to master: This changeset changes 48816 violations, introduces 26229 new violations, 5 new errors and 0 new configuration errors, removes 147786 violations, 27 errors and 3 configuration errors. Full report
✅	Compared to pmd/7.0.x: This changeset changes 81 violations, introduces 6753 new violations, 0 new errors and 0 new configuration errors, removes 0 violations, 0 errors and 0 configuration errors. Full report
✅	Compared to master: This changeset changes 45977 violations, introduces 25675 new violations, 38 new errors and 0 new configuration errors, removes 175335 violations, 28 errors and 3 configuration errors. Full report

Generated by 🚫 Danger

[oowekyala]

There is one fishy positive: https://github.com/checkstyle/checkstyle/blob/cfd1c333a866bd32912a1947e86ac0fceaf3ad65/src/test/resources/com/puppycrawl/tools/checkstyle/checks/suppresswarningsholder/InputSuppressWarningsHolder5.java#L11-L13

Maybe we should allow dups in annotations?

[adangel]

Maybe we should allow dups in annotations?

It turns out, we have already a property to do this: "skipAnnotations". It is by default off, so by default the rule will report duplicated string literals in annotations.
These new violations appeared, because PMD7 can now parse the whole file (PMD6 just failed parsing the file InputSuppressWarningsHolder5.java).

The question remains however: Would it make sense to switch the default of this property?

I don't see any report for this case, so I would argue, we just keep it as-is.
I'll add it for now to https://github.com/pmd/pmd/wiki/PMD-7.0.0-Java#other-quirks-about-current-rules that we can consider this again later.

[oowekyala]

I'm fine wth that solution