Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix missing --file arg in TreeExport CLI example #4116

Merged
merged 2 commits into from
Sep 11, 2022
Merged

[core] Fix missing --file arg in TreeExport CLI example #4116

merged 2 commits into from
Sep 11, 2022

Conversation

mohan-chinnappan-n
Copy link
Contributor

@mohan-chinnappan-n mohan-chinnappan-n commented Sep 9, 2022 •
edited by adangel
Loading

Describe the PR

missing --file arg in TreeExport - "Example: ast-dump --format xml --language java --file MyFile.java" added

The official doc is correct: https://pmd.github.io/latest/pmd_devdocs_experimental_ast_dump.html

Related issues

  • Fixes "[core] Missing --file arg in TreeExport CLI example"

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@mohan-chinnappan-n
Update TreeExportCli.java
11b7bda 
missing --file arg in "Example: ast-dump --format xml --language java --file MyFile.java" added
@mohan-chinnappan-n
Merge pull request #3 from mohan-chinnappan-n/mohan-chinnappan-n-patch-1
9ebabbe 
Update TreeExportCli.java
@mohan-chinnappan-n
Copy link
Contributor Author

Updating TreeExportCli.java for the correct usage message

@pmd-test
Copy link

pmd-test commented Sep 9, 2022

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel added this to the 6.50.0 milestone Sep 9, 2022
@adangel adangel self-requested a review September 10, 2022 07:14
@adangel adangel changed the title missing --file arg in TreeExport - "Example: ast-dump --format xml --language java --file MyFile.java" added [core] Fix missing --file arg in TreeExport CLI example Sep 11, 2022
adangel
adangel approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit to adangel/pmd that referenced this pull request Sep 11, 2022
@adangel
[doc] Update release notes (pmd#4116)
91d8930
adangel added a commit to adangel/pmd that referenced this pull request Sep 11, 2022
@adangel
Merge pull request pmd#4116 from mohan-chinnappan-n:master
cb9a660 
[core] Fix missing --file arg in TreeExport CLI example pmd#4116
@adangel adangel merged commit 9ebabbe into pmd:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.50.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohan-chinnappan-n @pmd-test @adangel